Conversation
Signed-off-by: Roman <4833306+Filter94@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts GitHub Actions caching behavior for the arithmetization zkc weekly metrics workflow by making cache usage configurable and disabling (or limiting) cache interactions for the weekly measurement run.
Changes:
- Add
cache-enabledinput to the arithmetization RISC-V setup action and disable it in the weekly metrics workflow. - Add
cache-enabledinput to the zkc measurement setup action and wire it intoactions/setup-gocaching. - Add a
cache-lookup-onlymode to the Zig setup action and pass it through toactions/cachevialookup-only.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/arithmetization-weekly-zkc-metrics.yml | Disables caching for the weekly metrics workflow’s environment setup. |
| .github/actions/setup-zkc-measurement/action.yml | Introduces a toggle to enable/disable Go caching during zkc measurement setup. |
| .github/actions/setup-zig/action.yml | Adds restore-only (“lookup-only”) cache mode for Zig cache restores without saves. |
| .github/actions/setup-arithmetization-riscv/action.yml | Adds cache toggle for Go and ties Zig cache to restore-only when caching is disabled. |
Suppressed comments (1)
.github/actions/setup-zkc-measurement/action.yml:40
- The comment here says the Zig cache is restore-only and that dispatched runs "read caches but never save", but this composite action doesn't interact with Zig caching and its Go cache behavior is controlled by
inputs.cache-enabled. As written, the comment is misleading; please update it to match the actual caching behavior and thecache-enabledknob.
# ref alone. Do not add a measured checkout to that job. The measured jobs' Go module/build cache
# is disabled and the Zig cache runs restore-only (lookup-only), so a dispatched run reads caches
# but never saves into the refs/heads/main-scoped cache namespace.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+22
to
+25
| cache-enabled: | ||
| description: 'Whether the Go module/build cache is enabled.' | ||
| required: false | ||
| default: 'false' |
Signed-off-by: Roman <4833306+Filter94@users.noreply.github.com>
nadeemb53
approved these changes
Aug 25, 2026
fluentcrafter
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist
PR.