ci(sdk): require approved npm publishing environment - #3797
Draft
eloi010 wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Eloi Manuel <eloi.manuel@consensys.net>
eloi010
force-pushed
the
fix/npm-publish-environment
branch
from
August 14, 2026 15:47
9b4e76a to
1266891
Compare
eloi010
marked this pull request as draft
August 14, 2026 15:54
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens SDK publishing with protected-environment approval, least-privilege permissions, and verified release commits.
Changes:
- Gates real npm releases behind
npm-publish. - Verifies and consistently uses a commit from
origin/main. - Scopes permissions per job while keeping dry runs approval-free.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm-publishenvironment for real SDK releases while keeping dry-run preflight checks approval-freeorigin/mainand use the verified commit for checkout, tags, and GitHub ReleasesValidation
actionlint .github/workflows/sdk-publish.ymlgit diff --checkThe workflow was not dispatched and no package was published.