This repository has been archived by the owner on Apr 21, 2024. It is now read-only.
!Pulse now checks the discord status api #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulse will now be able to get discord's component operating status.
Gaiwecoor
suggested changes
May 17, 2021
Comment on lines
+150
to
+151
| fetch("https://srhpyqt94yxb.statuspage.io/api/v2/summary.json").then(res => res.json()) | ||
| .then((json) => { |
There was a problem hiding this comment.
fetch isn't defined anywhere. For consistency sake, recommend requiring axios at the top and using that.
In addition, using .then() in an async function is generally seen as bad form. Better to use await here.
There was a problem hiding this comment.
oh, I was using node fetch. Sorry about that. I don't know axios.
Comment on lines
+181
to
+182
| fetch("https://srhpyqt94yxb.statuspage.io/api/v2/summary.json").then(res => res.json()) | ||
| .then((json) => { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulse will now be able to get discord's component operating status.