Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cerati factorize nu graph #49

Merged
merged 14 commits into from
Dec 18, 2024

Conversation

cerati
Copy link
Contributor

@cerati cerati commented Dec 6, 2024

Followup PR to #48 . As discussed there, this PR factorizes the code so that most of the tasks are delegated to tools that can be reused across producers. This also will allow experiment-specific or network-version-specific customizations.
Keeping @mhlswang and @vhewes in the loop.

@FNALbuild
Copy link
Contributor

A new Pull Request was created by @cerati for develop.

It involves the following packages:

larrecodnn

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

Copy link
Member

@knoepfel knoepfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cerati, for this PR--some nice cleanups here. I've added some comments/suggestions for your consideration. Let me know if you'd like to discuss anything further.

larrecodnn/NuGraph/Tools/DecoderToolBase.h Outdated Show resolved Hide resolved
larrecodnn/NuGraph/Tools/FilterDecoder_tool.cc Outdated Show resolved Hide resolved
larrecodnn/NuGraph/Tools/FilterDecoder_tool.cc Outdated Show resolved Hide resolved
larrecodnn/NuGraph/Tools/LoaderToolBase.h Outdated Show resolved Hide resolved
larrecodnn/NuGraph/Tools/SemanticDecoder_tool.cc Outdated Show resolved Hide resolved
larrecodnn/NuGraph/Tools/VertexDecoder_tool.cc Outdated Show resolved Hide resolved
larrecodnn/NuGraph/NuGraphInferenceTriton_module.cc Outdated Show resolved Hide resolved
larrecodnn/NuGraph/NuGraphInference_module.cc Outdated Show resolved Hide resolved
larrecodnn/NuGraph/Tools/DecoderToolBase.h Outdated Show resolved Hide resolved
larrecodnn/NuGraph/NuGraphInferenceSonicTriton_module.cc Outdated Show resolved Hide resolved
@FNALbuild
Copy link
Contributor

Pull request #49 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@cerati
Copy link
Contributor Author

cerati commented Dec 13, 2024

@knoepfel many thanks for the suggestions. I think I implemented them all in the commit above

@knoepfel
Copy link
Member

Thanks, @cerati. Will approve once the CI comes back successful.

@knoepfel
Copy link
Member

trigger build

@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@lgarren
Copy link
Member

lgarren commented Dec 16, 2024

approve

@FNALbuild
Copy link
Contributor

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren merged commit 04149b2 into LArSoft:develop Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Included in release
Development

Successfully merging this pull request may close these issues.

4 participants