-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cerati factorize nu graph #49
Feature/cerati factorize nu graph #49
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cerati, for this PR--some nice cleanups here. I've added some comments/suggestions for your consideration. Let me know if you'd like to discuss anything further.
Pull request #49 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again. |
The code-checks are being triggered in jenkins. |
+code-checks |
@knoepfel many thanks for the suggestions. I think I implemented them all in the commit above |
Thanks, @cerati. Will approve once the CI comes back successful. |
trigger build |
The tests are being triggered in jenkins. |
+LArSoft tests OK on slf7 for c14:prof |
+LArSoft tests OK on slf7 for e26:prof |
-uBooNE tests failed on slf7 for e26:prof |
-SBND tests failed on slf7 for e26:prof |
-ICARUS tests failed on slf7 for e26:prof |
-DUNE tests warning on slf7 for e26:prof |
approve |
This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. |
Followup PR to #48 . As discussed there, this PR factorizes the code so that most of the tasks are delegated to tools that can be reused across producers. This also will allow experiment-specific or network-version-specific customizations.
Keeping @mhlswang and @vhewes in the loop.