Expand javadocs #229
Merged
Expand javadocs #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdcfe
reviewed
Dec 9, 2020
api/src/main/java/net/kyori/adventure/text/format/TextColor.java
Outdated
Show resolved
Hide resolved
kashike
requested changes
Dec 9, 2020
kashike
reviewed
Dec 9, 2020
api/src/main/java/net/kyori/adventure/translation/GlobalTranslator.java
Outdated
Show resolved
Hide resolved
mdcfe
reviewed
Dec 11, 2020
api/src/main/java/net/kyori/adventure/translation/GlobalTranslator.java
Outdated
Show resolved
Hide resolved
dualspiral
reviewed
Dec 11, 2020
There was a problem hiding this comment.
kashike asked me to give some thoughts. Here are some thoughts. Hopefully they help.
I didn't expect someone to jump at my issue for javadocs so quickly - so thanks for taking a look! I figured that I'd just get poked down the line by someone saying "well, you asked for this..."
api/src/main/java/net/kyori/adventure/text/BlockNBTComponent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/EntityNBTComponent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/LinearComponents.java
Outdated
Show resolved
Hide resolved
|
Thanks for all feedback i have not responded to yet, i will pick this up on sunday :) |
zml2008
requested changes
Dec 11, 2020
api/src/main/java/net/kyori/adventure/translation/TranslationRegistry.java
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/format/TextColor.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/LinearComponents.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/StorageNBTComponent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/TranslatableComponent.java
Outdated
Show resolved
Hide resolved
kashike
requested changes
Dec 16, 2020
api/src/main/java/net/kyori/adventure/translation/GlobalTranslator.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/TranslatableComponent.java
Outdated
Show resolved
Hide resolved
KingOfSquares
force-pushed
the
javadocs
branch
from
90df41d to
a8d7e62
Compare
kashike
approved these changes
Dec 21, 2020
zml2008
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw #226 and typed out a draft for a possible javadocs expansion, feedback appreciated.