fix(install): remove self-referencing shared lib path - #24
Merged
sshanks-kx merged 1 commit intoJul 29, 2026
Merged
Conversation
The assignment referenced ${Q_SHARED_LIB_DIR} on the right-hand side
before it was defined. It resolved to empty by accident, producing the
correct path, but the self-reference was confusing and fragile.
Fix: remove the self-reference from the assignment.
sshanks-kx
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Q_SHARED_LIB_DIR construction so it does not accidentally include an inherited Q_SHARED_LIB_DIR environment value. The destination path should be derived only from QHOME, host type, machine type, and path separator.