Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): build error of node v23 #781

Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix(ui): build error of node v23 #781

merged 2 commits into from
Feb 7, 2025

Conversation

hai-tian
Copy link
Collaborator

@hai-tian hai-tian commented Feb 7, 2025 •
edited by elliotxx
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix build error of node v23

Which issue(s) this PR fixes:

Fixes #

@elliotxx elliotxx changed the title fix: fix build error of node v23 fix(ui): build error of node v23 Feb 7, 2025
elliotxx
elliotxx approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit c1a6f6e into main Feb 7, 2025
13 checks passed
@elliotxx elliotxx deleted the fix-upgrading-nodeV23-build-error branch February 7, 2025 03:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@ruquanzhao ruquanzhao Awaiting requested review from ruquanzhao ruquanzhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hai-tian @elliotxx