Lesson5 #5
Open
Lesson5 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Om1X
suggested changes
Sep 6, 2020
Comment on lines
+24
to
+46
| getRequest(jsonFile) { | ||
|
|
||
| return new Promise((resolve, reject) => { | ||
|
|
||
| var xhr = new XMLHttpRequest(); | ||
| xhr.open('GET', `${API}${jsonFile}`, true); | ||
|
|
||
| xhr.onreadystatechange = () => { | ||
| if (xhr.readyState === 4) { | ||
| if (xhr.status === 200) { | ||
| let response = JSON.parse(xhr.responseText); | ||
| resolve(response); | ||
| } else { | ||
| reject('Error'); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| xhr.send(); | ||
|
|
||
| }); | ||
|
|
||
| }, |
There was a problem hiding this comment.
у нас же был прекрасный метод с fetch, зачем усложнять?
Comment on lines
+78
to
+79
| this.basket.push(0); | ||
| this.basket.pop(); |
There was a problem hiding this comment.
костыль-костыльный =( Если и идти такой дорогой то тут больше Vue.set поможет но в целом реализация у нас итак уже есть + повторил про нее на уроке.
| console.log(data); | ||
| for (let item of data) { | ||
| console.log(typeof(item)); | ||
| item['class'] = 'visible'; |
There was a problem hiding this comment.
это можно вынести в шаблон, ибо хранить данные о стилях в списке товаров, которые вообще не должны содержать данные о представлении.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.