Skip to content

Outputing the function counter to XML. - #223

Open
giulianobelinassi wants to merge 6 commits into
Kuniri:devfrom
kuniri-xp:functions_counter
Open

Outputing the function counter to XML.#223
giulianobelinassi wants to merge 6 commits into
Kuniri:devfrom
kuniri-xp:functions_counter

Conversation

@giulianobelinassi

Copy link
Copy Markdown
Contributor

Now, globalFunctions tag appears in the header of the xml output file.

@rodrigosiqueira

Copy link
Copy Markdown
Member
  1. Change globalFunctions name to totalGlobalFunctions
  2. When we execute kuniri with O1 flag it optimizes the final output to use a reduced version of the elements name. totalGlobalFunctions could be reduced to tgf and count to c when -O1 is passed to the CLI.
    Thanks :)

giulianobelinassi and others added 2 commits May 24, 2017 14:02
Now, globalFunctions tag appears in the header of the xml output file.
For now, globalFunctions = totalGlobalFunctions, and has 'tfg' as short label.

Signed-off-by: Lucas Kanashiro <kanashiro@debian.org>
Signed-off-by: Giuliano Belinassi <giuliano.belinassi@usp.br>
After changing globalFunctions to totalGlobalFunctions some tests broke.

Signed-off-by: Lucas Kanashiro <kanashiro@debian.org>
Signed-off-by: Giuliano Belinassi <giuliano.belinassi@usp.br>
@rodrigosiqueira

Copy link
Copy Markdown
Member

Almost done...
I just miss some tests similar the ones find in spec/language/ruby/global_test/. Add rspec tests with multiple variation of this parameter and other similar with tests in spec/language/ruby/global_test/

Signed-off-by: Bruno Sesso <bruno.sesso@usp.br>
Signed-off-by: Giuliano Belinassi <giuliano.belinassi@usp.br>
@giulianobelinassi

Copy link
Copy Markdown
Contributor Author

Done. Check spec/language/ruby/global_test/metrics

@rodrigosiqueira

Copy link
Copy Markdown
Member

Almost done, can you just rebase your branch with dev and fix the conflicts?

giulianobelinassi and others added 2 commits June 9, 2017 15:34
Signed-off-by: giulianobelinassi <giuliano.belinassi@usp.br>
Signed-off-by: Lucas Kanashiro <kanashiro@debian.org>
Signed-off-by: Bruno Sesso <bsesso@gmail.com>
@giulianobelinassi

giulianobelinassi commented Jun 21, 2017

Copy link
Copy Markdown
Contributor Author

We do not know why the build is failing, but all tests succeed in my machine. @rodrigosiqueira Could you run it locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants