Conversation
YinBuLiao
marked this pull request as draft
September 23, 2026 08:02
YinBuLiao
marked this pull request as ready for review
September 23, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Fixes macOS update checks that failed with HTTP 403, and adds in-app installation of the downloaded macOS application in the same PR.
SHA256SUMSasset. If verified package metadata is unavailable, version discovery still works and manual download remains available..app, relaunches it and restores the workspace. Install on next launch uses the same transaction. Immediate launch failure restores the original app; cancellation, a bad package or another running copy leaves the original untouched.Design / 设计边界
update_check::assets; streaming, checksums and transaction/restore authority remain inupdate_download. The macOS platform adapter owns native process, signature, mount and filesystem operations.Evidence / 验证依据
Locally verified on macOS ARM64:
cargo test --offline --locked -p nebula --bin pebrel --features gpui-test-support,gpui_platform/runtime_shaders update_ -- --test-threads=1: 52 passed, 2 explicit acceptance tests ignored by default.restored.jsonwas written. Same-version reinstall is a test-only facility, not shipped update behavior. The update dialog retains its compact horizontal footer. The Chinese ready hint is shortened to avoid an orphan full stop, and English action labels are shortened to fit. Exhaustive hover/keyboard/DPI and native Korean review are not claimed.cargo fmt --all -- --check,git diff --check, and architecture check against base0110c7cpassed. No budgets changed.Required Review / 必须确认
CONTRIBUTING.md, architecture and engineering contracts.