Skip to content

fix(updater): handle busy helpers and same-version repairs - #261

Merged
Kuddev merged 3 commits into
mainfrom
fix/feedback-update-repair-20260923
Sep 23, 2026
Merged

Kuddev merged 3 commits into
mainfrom
fix/feedback-update-repair-20260923

Conversation

@Kuddev

@Kuddev Kuddev commented Sep 23, 2026

Copy link
Copy Markdown
Owner

Result / 用户结果

A verified same-version installer can repair a previously locked helper while leaving the main executable byte-identical. The updater now accepts that successful repair instead of reporting “Same-version installation did not replace the application binary”. Fixes #258.

Design / 设计边界

Installer success and the expected reported application version remain required. Package size/SHA-256 verification, participant identity, commit authority and snapshot recovery are retained. The installed main hash is recorded as evidence, but is no longer an invalid same-version success condition. Before starting setup, a bounded preflight waits for installed Hook files to become writable. A persistent lock fails before setup can partially replace the installation. The causal note explains the partial-upgrade case and the limits of installed-file verification.

Evidence / 验证依据

  • Read the issue's supplied Inno log, which reports successful installation and no required Windows restart.
  • scripts/tests/test_update_handoff.ps1: all 12 native process-fixture scenarios passed.
  • repair-identical replaces the helper while retaining the main executable bytes and must succeed. upgrade-noop returns setup success but leaves the wrong version and must fail. Cancellation, failed setup, checksum/identity errors and unprepared processes remain covered.
  • helper-unlocked verifies transient locks are awaited; helper-held verifies persistent locks prevent setup entirely and recover the original application.
  • These are transaction/process fixtures, not a new formal installer release.

Required Review / 必须确认

  • Followed the contribution, architecture and project constraints.
  • Kept behavior in its owning module and preserved existing compatibility boundaries.
  • Architecture check against the PR base passes without budget increases.
  • Success/failure regressions and verification limits are described above.
  • No application message catalog changes; installer labels use the existing localized custom-message mechanism where applicable.
  • No governance rules or server-side protection settings were changed.

@Kuddev
Kuddev marked this pull request as ready for review September 23, 2026 07:07
@Kuddev Kuddev changed the title fix(updater): accept successful byte-identical same-version repairs fix(updater): handle busy helpers and same-version repairs Sep 23, 2026
@github-actions github-actions Bot added the size/S ≤100 行源码改动 label Sep 23, 2026
@Kuddev
Kuddev merged commit d9f2ce0 into main Sep 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S ≤100 行源码改动

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 同版本重装成功后,更新器误报 “Same-version installation did not replace the application binary”

1 participant