Enable browser access and publish MCP endpoints - #1416
Conversation
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (28)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe gateway now supports browser CORS preflight and response headers, removes browser-scoped headers before upstream forwarding, and publishes the resolved MCP URL through ChangesBrowser access and endpoint publication
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The browser-access and MCP endpoint changes introduce no actionable merge-blocking risk at the current head; the PR is merge-ready after normal checks and review. Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9ab05f0 to
2185e98
Compare
Handle browser CORS in ext_proc without adding gateway or route configuration. Publish the client URL in status.mcpEndpoint. Relates-to: Kuadrant#604 Relates-to: Kuadrant/kuadrant-console-plugin#752 Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
Document the VPN and no-auth caveat, explain that the gateway owns Origin validation, and cover the preflight versus AuthPolicy boundary in the auth E2E suite. Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
2185e98 to
ceca711
Compare
|
@david-martin added some additional docs re: security + CORS per our discussion earlier |
Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
cc792ba to
a708afe
Compare
|
|
||
| // mcpEndpoint is the public URL for MCP clients. | ||
| // +optional | ||
| MCPEndpoint string `json:"mcpEndpoint,omitempty"` |
There was a problem hiding this comment.
TODO: is this necesary? surely it's derivable.. need to look.
Summary
status.mcpEndpoint.Test evidence
make lint-go,make check,make test-unit, andmake test-controller-integrationRelates to #604 and Kuadrant/kuadrant-console-plugin#752.
Summary by CodeRabbit
New Features
Documentation