fix missing params for upstream.MCPNamein filtered_tools_handler - #1180
Conversation
Signed-off-by: rogueslasher <aniketpandey25092005@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughSingle-character fix in ChangesFix MCPName() method call in debug log
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@david-martin @jasonmadigan @maleck13 this one can be merged too it fixes the missing () |
|
Thanks for the contribution, @rogueslasher! You currently have other non-draft PR(s) open: To help us review and merge changes as efficiently as possible, we ask contributors to focus on one PR at a time. Activity on this project can be high, and maintainers have other priorities outside the project, so having a single active PR helps everyone get changes landed faster. Please convert this PR to draft while your other PR(s) are in review. Once they are merged or closed, mark this one as ready for review and we will take a look. Note This is an experimental process and may change or need manual intervention while we trial it. |
|
@rogueslasher, Confirmed.., Optional: you can actually drop the call here. |
What does this PR do?
Fixes incorrect logging in filtered_tools_handler.go by invoking upstream.MCPName() instead of referencing the method value. This ensures the actual upstream MCP server name is included in log messages, improving observability and debugging.
Summary by CodeRabbit