-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing glob imports, added script to detect dangling imports #188
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonmadigan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for graceful-kangaroo-3c9c10 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
be6536c
to
152774d
Compare
…ts from the nav Signed-off-by: Jason Madigan <[email protected]>
152774d
to
a0c3b1f
Compare
@david-martin fyi - ready for review. I did keep some of the image globs in the end, but none of the doc ones. |
👀 |
/lgtm This highlights the high number of files that are still being published because they are linked to, but don't have a location in the nav. The changes in the PR are sufficient to satisfy #181. |
python3 validate_imports.py