Skip to content

fix release pipeline #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KrishKrosh merged 1 commit into from
Jul 27, 2025
Merged

fix release pipeline #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/build-and-sign-dmg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,16 @@ jobs:
xcode-version: latest-stable

- name: Import Code-Signing Certificates
if: ${{ secrets.BUILD_CERTIFICATE_BASE64 != '' }}
if: ${{ env.BUILD_CERTIFICATE_BASE64 != '' }}
env:
BUILD_CERTIFICATE_BASE64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
uses: Apple-Actions/import-codesign-certs@v2
with:
p12-file-base64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
p12-password: ${{ secrets.P12_PASSWORD }}

- name: Install provisioning profile
if: ${{ secrets.BUILD_PROVISION_PROFILE_BASE64 != '' }}
if: ${{ env.BUILD_PROVISION_PROFILE_BASE64 != '' }}
env:
BUILD_PROVISION_PROFILE_BASE64: ${{ secrets.BUILD_PROVISION_PROFILE_BASE64 }}
run: |
Expand Down Expand Up @@ -103,8 +105,9 @@ jobs:
-exportArchive

- name: Re-sign App Components
if: ${{ secrets.BUILD_CERTIFICATE_BASE64 != '' }}
if: ${{ env.BUILD_CERTIFICATE_BASE64 != '' }}
env:
BUILD_CERTIFICATE_BASE64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
run: |
echo "🔏 Re-signing framework with Developer ID certificate..."
Expand Down Expand Up @@ -136,7 +139,9 @@ jobs:
echo "✅ Application re-signed successfully"

- name: Verify Code Signatures
if: ${{ secrets.BUILD_CERTIFICATE_BASE64 != '' }}
if: ${{ env.BUILD_CERTIFICATE_BASE64 != '' }}
env:
BUILD_CERTIFICATE_BASE64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
run: |
echo "🔍 Verifying main application signature..."
codesign --verify --verbose "$RUNNER_TEMP/export/${{ env.APP_NAME }}.app"
Expand All @@ -153,8 +158,9 @@ jobs:
echo "✅ All signature verifications passed"

- name: Notarize App
if: ${{ secrets.BUILD_CERTIFICATE_BASE64 != '' && secrets.APPLE_ID != '' }}
if: ${{ env.BUILD_CERTIFICATE_BASE64 != '' && env.APPLE_ID != '' }}
env:
BUILD_CERTIFICATE_BASE64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
Expand Down
Loading