Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Swapper #36

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

CSS Swapper #36

wants to merge 9 commits into from

Conversation

eeonaa
Copy link

@eeonaa eeonaa commented Nov 13, 2024

  • In-Game CSS swapper with hot swapping
  • Separate file path config/css to stop the resource swapper scope bug
  • Works with any file put into config/css

@KraXen72
Copy link
Owner

Thanks for the pr! i'll try testing this and then let you know if it behaves like i had in mind.

@thgilciffart
Copy link

how about a resource swapper swapper? would allow for mod + css swaps

@KraXen72
Copy link
Owner

can you elaborate a bit

@thgilciffart
Copy link

extend the idea to the entire swapper unless i'm misinterpreting you'd have mutiple css in one folder and you can swap between them. Perhaps you can extend it into the resource swapper where you'd have the mod you want or even have individual sections ie textures, sounds, shaders and you could easily mix between them

@AspectQuote
Copy link
Contributor

extend the idea to the entire swapper unless i'm misinterpreting you'd have mutiple css in one folder and you can swap between them. Perhaps you can extend it into the resource swapper where you'd have the mod you want or even have individual sections ie textures, sounds, shaders and you could easily mix between them

Krunker already allows for changing mods easily like this through the 'mods' page. The built-in resource swapper functions in the exact same way as a Krunker mod apart from loading main_custom.css. Krunker has mod favoriting as well and that would function almost identically to what you're requesting, unless I'm misinterpreting you

@KraXen72
Copy link
Owner

yeah i think having a swapper swapper is a bit too overcomplicated, both as from an implementation/maintaining perspective and from a user's perspective where most ppl wouldn't know how in works or why is setting up a swapper so complicated.

@KraXen72
Copy link
Owner

also i'm gonna review both this and aspect's pr soontm just was busy with other things + i gotta find the zip of my resswapper somewhere, lol

@KraXen72
Copy link
Owner

KraXen72 commented Jan 3, 2025

@eeonaa i've reviewed it, the code looks fine. please resolve conflicts and i'll merge it.

@eeonaa
Copy link
Author

eeonaa commented Jan 4, 2025

Resolved and updated to newest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants