Repository navigation
Document import discipline for the CLI cold path - #40
Merged
KraHsu merged 1 commit intoMay 15, 2026
Merged
Conversation
Add an "Import discipline" section to CONTRIBUTING.md (and its bilingual mirror in docs/contributing.zh.md) describing the constraint and the PEP 562 __getattr__ pattern. Locks in the convention introduced by the lazy-import work on genelab/__init__.py, genelab/utils/__init__.py, and genelab.configs so future re-exports do not re-introduce torch into the CLI cold path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #39. Adds an Import discipline section to
CONTRIBUTING.mdand its bilingual mirrordocs/contributing.zh.md, locking in the convention introduced by the lazy-import work ongenelab/__init__.py,genelab/utils/__init__.py, andgenelab.configs.The section spells out:
import torch/ Genesis from a top-level__init__.py.__getattr__pattern for re-exports.genelab.configsand theNameError-tolerant_field_annotation.Goal: prevent a future PR from silently regressing the CLI cold path back to ~850 ms.
Test plan
uv run mkdocs build --strict— clean (en + zh in parity, anchors resolve)feat/cli-interactive-completion); merge that first, then this rebases trivially