Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failing on systems without IPv6 support #1667

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jackwilsdon
Copy link
Contributor

This test fails if IPv6 is disabled:

____________________ TestBaseServerRequests.test_bind_fail _____________________

self = <radicale.tests.test_server.TestBaseServerRequests object at 0x7ffff4e2b8f0>

    def test_bind_fail(self) -> None:
        for address_family, address in [(socket.AF_INET, "::1"),
                                        (socket.AF_INET6, "127.0.0.1")]:
>           with socket.socket(address_family, socket.SOCK_STREAM) as sock:

radicale/tests/test_server.py:144: 

This PR just copies the IPv6 check from test_ipv6, skipping an address if it's not supported.

@pbiering pbiering added this to the 3.3.4 milestone Jan 2, 2025
@pbiering pbiering merged commit 45f2a4c into Kozea:master Jan 2, 2025
22 checks passed
@jackwilsdon jackwilsdon deleted the fix-ipv6-test branch January 2, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants