Export: Check if export path exists

Prevent ``shutil.move`` from moving to .../root
Kozea · Jul 24, 2017 · 715a90b · 715a90b
1 parent d069be5
commit 715a90b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/radicale/__main__.py b/radicale/__main__.py
@@ -130,8 +130,11 @@ def export_storage(config, path, debug=False):
                     traceback.print_exc()
                 exit(1)
         try:
+            # This check is prone to a race condition
+            if os.path.exists(path):
+                raise Exception("Destination path %r already exists" % path)
             shutil.move(os.path.join(temp, "root"), path)
-        except (OSError, shutil.Error) as e:
+        except Exception as e:
             print("ERROR: Can't create %r directory: %s" % (path, e))
             if debug:
                 traceback.print_exc()