Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings generator: use single Mac agent for deployment #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ilya-g
Copy link
Member

@ilya-g ilya-g commented Sep 1, 2023

No description provided.

@ilya-g ilya-g requested a review from qurbonzoda September 1, 2023 17:09
@ilya-g ilya-g force-pushed the ig/publishing-agent branch from 098c56c to 96a46c3 Compare September 13, 2023 17:02
@ilya-g
Copy link
Member Author

ilya-g commented Sep 13, 2023

I've decided to rework the approach a bit: instead of doing it unconditionally, introduce an option for that, because there can be situations where cross-compilation on macs may be insufficient.

/**
* Build all artifacts for publishing and deploy them from a single mac agent.
*/
var singleAgentMacDeployment: Boolean = false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, it'd be better to place it in teamcity DSL block because it affects generated teamcity build configurations?
On the other hand, libraryStagingRepoDescription was recently moved (see the commit 25e3650) from teamcity to publishing/sonatype block, because while it also affects TC configurations, it is semantically closer to sonatype publishing.
WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "publishing" DSL is the appropriate place for the property. It affects publishing, even if only in TeamCity.

@qurbonzoda
Copy link
Contributor

Is the ability to publish artifacts for all targets documented somewhere?
I just need to better understand the cross-compilation feature in order to review the MR properly.

@ilya-g
Copy link
Member Author

ilya-g commented Oct 4, 2023

Cross-compiling for Linux on Mac hosts existed for a long time, and cross-compiling for Windows was announced in one of recent releases: https://kotlinlang.org/docs/whatsnew16.html#compilation-of-windows-targets-on-any-host

But in my experiment, the artifacts I've got on a Mac agent were slightly different, so I'd like to study it a bit more before enabling for production publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants