Skip to content

Add a guide to benchmark configuration options #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

qurbonzoda
Copy link
Contributor

@qurbonzoda qurbonzoda commented Nov 29, 2023

Followup to #167

The changes were developed within GSoC 2023 program by our mentee @wldeh.

Copy link
Collaborator

@fzhinkin fzhinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is great, but it is missing examples. It would be nice to put a reference to some sample project, site its configuration and then describe what to expect.
For instance, "here's a project with multiple benchmarks; we're excluding this and including that; here's what will be actually executed and here's a sample of an output".

@fzhinkin
Copy link
Collaborator

Oh, and the jhmVersion property is not documented here. Given the really old version used by default (1.21), it's necessary to mention how to switch to a more up-to-date version.

OndrejSliva pushed a commit to OndrejSliva/kotlinx-benchmark that referenced this pull request Jan 10, 2024
…e.googlejavaformat-google-java-format-1.19.2

build(deps): bump com.google.googlejavaformat:google-java-format from 1.19.1 to 1.19.2
@qurbonzoda
Copy link
Contributor Author

Oh, and the jhmVersion property is not documented here. Given the really old version used by default (1.21), it's necessary to mention how to switch to a more up-to-date version.

@fzhinkin, Done. PTAL.

@qurbonzoda qurbonzoda mentioned this pull request Jan 26, 2024
@qurbonzoda qurbonzoda force-pushed the add-configuration-options-guide branch from e39c833 to 76700ad Compare February 8, 2024 23:01
@qurbonzoda qurbonzoda changed the base branch from improve-readme to master February 8, 2024 23:02
@qurbonzoda qurbonzoda merged commit 96fe988 into master Feb 8, 2024
@qurbonzoda qurbonzoda deleted the add-configuration-options-guide branch February 9, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants