Build warnings as errors #509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will force to address any plugin or Gradle deprecations in the build scripts on any update.
It is the deprecated interface.
…n and dependencies This OptIn is not available in the compilation classpath.
Tapchicoma
commented
Feb 10, 2025
| @@ -267,7 +267,7 @@ private fun Project.withKotlinTargets(fn: (KotlinTarget) -> Unit) { | |||
| } | |||
| } | |||
|
|
|||
| private fun KotlinCompile<*>.setFriendPaths(friendPathsFileCollection: FileCollection) { | |||
| private fun KotlinCompilationTask<*>.setFriendPaths(friendPathsFileCollection: FileCollection) { | |||
There was a problem hiding this comment.
I am not sure KotlinCompilationTask type is available in KGP 1.7.0. In general, I think it is time to bump minimal supported versions of Gradle and KGP in this project.
There was a problem hiding this comment.
AFUPlugin requires Kotlin plugin version to be at least 1.9.0 already, so I guess, it's ok?
It was hardcoded here, instead of using the declared const value :(
There was a problem hiding this comment.
With Kotlin 1.9.0 it should fine - this interface was introduced in Kotlin 1.8.0 alongside compilerOptions DSL.
There was a problem hiding this comment.
I could try to update the logic to use the constant as I was also confused with it value. Are you ok with it?
mvicsokolova
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've enabled warning-as-errors mode in build scripts and Gradle plugin compilation to avoid usages of deprecated methods.