Add api kotlinx-atomicfu dependency for JS and WASM targets. #475
Conversation
mvicsokolova
force-pushed
the
api-js-dependency
branch
from
9a1c129 to
791316d
Compare
mvicsokolova
force-pushed
the
api-js-dependency
branch
from
791316d to
b9a4c16
Compare
...esting/src/functionalTest/kotlin/kotlinx.atomicfu.gradle.plugin.test/cases/MppProjectTest.kt
Show resolved
Hide resolved
...onalTest/kotlin/kotlinx.atomicfu.gradle.plugin.test/framework/checker/DependenciesChecker.kt
Outdated
Show resolved
Hide resolved
| @@ -50,6 +50,11 @@ kotlin { | |||
| } | |||
| } | |||
|
|
|||
| // Workaround for KT-71203. Can be removed after https://github.com/Kotlin/kotlinx-atomicfu/issues/431 | |||
| atomicfu { | |||
| transformJs = false | |||
There was a problem hiding this comment.
Should users apply the same change to their projects to use AFU w/ this PR applied without having "clashing unique_name property" error?
There was a problem hiding this comment.
I'm preparing a fix for that rn: I'll set transformJs value to false by default
There was a problem hiding this comment.
But if, for some reason, they have this property explicitly enabled, they will get the cryptic error message anyway?
There was a problem hiding this comment.
Starting with Kotlin 2.0.20 -- yes
There was a problem hiding this comment.
And I'll deprecate this property with a warning
There was a problem hiding this comment.
Maybe we should also print an explicit warning describing the problem to guide users toward the solution? Personally, I'm struggling to link KLIB resolver blablabla unique_name blablabla with atomicfu.transformJs :)
As of #431, I remember we agreed that JS transformation removal sounds OK, but the final decision was pending (some additional research over potential downsides was required).
There was a problem hiding this comment.
Regarding #431 it's only related to JS IR, and I would do deprecation (and preliminary checks) of JS IR transformations for the next release.
transformJs only disabled/enabled legacy JS transformation and now, being still enabled by default, it just creates a new js directory, causing the problem, that you've mentioned. Removing transformJs flag and legacy transformation tasks would solve the problem 👀
There was a problem hiding this comment.
Got it, thanks.
Removing transformJs flag and legacy transformation tasks would solve the problem 👀
Sure, but there are a few projects that are still using it.
There was a problem hiding this comment.
I've prepared a PR removing legacy transformations and disabling/deprecating transformJs flag here: #478
With these changes, transformJs flag does not take any effect (specifically does not create an empty is directory which caused the above mentioned error), so for the user, who used transformJs there will just be a flag deprecation warning and the WA for this error will not be needed.
So, we can merge #478, then remove the WA for transformJs from this PR, merge it as well and then publish the 0.25.1 release.
mvicsokolova
force-pushed
the
api-js-dependency
branch
from
d91bd8b to
c4b0e5b
Compare
Fixes #448