-
Notifications
You must be signed in to change notification settings - Fork 43
Resolve conflicts of var-properties with different types #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss and move forward. I'm totally pro merging this and my goal for today is to move forward with all PR accumulated throughout previous wee as fast as possible.
...common/src/org/jetbrains/dukat/model/commonLowerings/overrides/VarConflictResolveLowering.kt
Outdated
Show resolved
Hide resolved
...common/src/org/jetbrains/dukat/model/commonLowerings/overrides/VarConflictResolveLowering.kt
Outdated
Show resolved
Hide resolved
...common/src/org/jetbrains/dukat/model/commonLowerings/overrides/VarConflictResolveLowering.kt
Outdated
Show resolved
Hide resolved
...common/src/org/jetbrains/dukat/model/commonLowerings/overrides/VarConflictResolveLowering.kt
Outdated
Show resolved
Hide resolved
(Then they are actually not conflicting in this case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still requesting changes - it's getting better but still some work to do before ending up in master )
|
||
val propertiesInImmediateParents = properties.filter { first -> | ||
properties.none { second -> | ||
inheritanceContext.isDescendant(second.ownerModel, first.ownerModel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should collect actual parent instead collecting all parents and then filtering out this way ) (check out ModelContext::getParents)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this case?
interface A {
x: number
}
interface B : A {
}
interface C : B {
x: number
}
I still want to get x from A in this case, that's why I can't use something like ModelContext::getParents. So I believe I'm right in this place -- the name can be misleading though, can you suggest what change it to?
No description provided.