Move to(Start) keeping inside group #1489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloMariaProietti
changed the title
Jolanrensen
requested changes
Oct 13, 2025
|
|
||
| /** | ||
| * Moves columns, previously selected with [move] to a new position specified | ||
| * by [columnIndex] within the column group (remaining inside the group). |
There was a problem hiding this comment.
*if insideGroup == true that is
| * ### Examples: | ||
| * ```kotlin | ||
| * df.move { age and weight }.to(0) | ||
| * df.move("age", "weight").to(2) |
There was a problem hiding this comment.
how about an example with insideGroup = true?
| * ``` | ||
| * | ||
| * @param [columnIndex] The index specifying the position in the [ColumnGroup] columns | ||
| * * where the selected columns will be moved. |
There was a problem hiding this comment.
no information about @param insideGroup
| public fun <T, C> MoveClause<T, C>.toStart(): DataFrame<T> = to(0) | ||
|
|
||
| /** | ||
| * Moves columns, previously selected with [move] to the start of their [ColumnGroup] (remaining inside the group). |
There was a problem hiding this comment.
only if insideGroup = true
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/move.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/move.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/move.kt
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| // move columns |
There was a problem hiding this comment.
probably easier to view the logic using a when
There was a problem hiding this comment.
and lift return out of the when-statement
Jolanrensen
reviewed
Oct 14, 2025
| * where the selected columns will be moved. | ||
| * | ||
| * @param [insideGroup] If true, selected columns will be moved remaining inside their group, | ||
| * else they will be moved on top level. |
Jolanrensen
reviewed
Oct 14, 2025
|
|
||
| /** | ||
| * Moves columns, previously selected with [move] to a new position specified | ||
| * by [columnIndex]. If insideGroup is true, selected columns will be moved remaining within their [ColumnGroup], |
There was a problem hiding this comment.
"insideGroup" can have "[]"
|
Oh, I see we also have these shortcut functions:
Could you do the same there as with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About #1255
It comes with docs and a test case