Skip to content

parseExperimentalUuid in ParserOptions #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jolanrensen
Copy link
Collaborator

Fixes #1304

Added parseExperimentalUuid parser option for parsing to experimental kotlin.uuid.Uuid.
False by default until it is no longer experimental.
Docs are updated as well.

Follow up from #1287

… kotlin.uuid.Uuid. False by default until it is no longer experimental
@@ -101,6 +107,8 @@ public interface GlobalParserOptions {
* @param skipTypes a set of types that should be skipped during parsing. Parsing will be attempted for all other types.
* By default, it's an empty set. To skip all types except a specified one, use [convertTo] instead.
* @param useFastDoubleParser whether to use [FastDoubleParser], defaults to `true`. Please report any issues you encounter.
* @param parseExperimentalUuid whether to allow parsing UUIDs to the experimental [kotlin.uuid.Uuid] type.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we now know that in notebooks dataframe properties with such type require additional opt in!

* Whether to allow parsing UUIDs to the experimental [kotlin.uuid.Uuid] type.
* By default, this is false and UUIDs are not recognized.
*/
public var parseExperimentalUuid: Boolean
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, do you plan to later rename this property later? It will be an incompatible change.. Or drop it completely? Should we call it "parseUuid" and provide note about experimental status in kdocs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make kotlin.uuid.Uuid parsing experimental via ParserOptions
2 participants