rename to valid camel case and remove deprecated URL()#1175
Merged
Conversation
zaleslaw
approved these changes
May 6, 2025
| ?.toKotlinLocalDateTime() | ||
|
|
||
| private fun String.toUrlOrNull(): URL? = if (isUrl(this)) catchSilent { URL(this) } else null | ||
| private fun String.toUrlOrNull(): URL? = if (isUrl(this)) catchSilent { URI(this).toURL() } else null |
| public fun asUrl(fileOrUrl: String): URL = | ||
| if (isUrl(fileOrUrl)) { | ||
| URL(fileOrUrl).toURI() | ||
| URI(fileOrUrl) |
Jolanrensen
approved these changes
May 6, 2025
Jolanrensen
left a comment
Jolanrensen
left a comment
Collaborator
There was a problem hiding this comment.
Did you do a Ctrl+f across the /dev example notebooks? Just to be sure we don't also use this function there :)
| * | ||
| * {@include [Indent]} | ||
| * `| `__`.`__[**`toURL`**][Convert.toURL]`()` | ||
| * `| `__`.`__[**`toURL`**][Convert.toUrl]`()` |
Collaborator
There was a problem hiding this comment.
you missed the first part of the reference
|
|
||
| // region toURL | ||
|
|
||
| @Deprecated(CONVERT_TO_URL, ReplaceWith(CONVERT_TO_URL_REPLACE)) |
Collaborator
There was a problem hiding this comment.
We might go to level = DeprecationLevel.ERROR directly, since we're breaking more stuff anyway
Collaborator
There was a problem hiding this comment.
I forgot, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1169