New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix description of `KaType.upperBoundIfFlexible` and `KaType.lowerBoundIfFlexible` #5

Open

Godin wants to merge 1 commit into Kotlin:main from Godin:fix_KaType_upperBoundIfFlexible_and_lowerBoundIfFlexible

Godin commented Dec 5, 2024

According to
https://github.com/JetBrains/kotlin/blob/2.1.0/analysis/analysis-api/src/org/jetbrains/kotlin/analysis/api/components/KaTypeProvider.kt#L106-L112

    public fun KaType.upperBoundIfFlexible(): KaType = withValidityAssertion {
        (this as? KaFlexibleType)?.upperBound ?: this
    }

    public fun KaType.lowerBoundIfFlexible(): KaType = withValidityAssertion {
        (this as? KaFlexibleType)?.lowerBound ?: this
    }

instead of null they return the given type itself.


          Fix description of KaType.upperBoundIfFlexible and `KaType.lowerBou…

f0f9589

…ndIfFlexible`

According to
https://github.com/JetBrains/kotlin/blob/2.1.0/analysis/analysis-api/src/org/jetbrains/kotlin/analysis/api/components/KaTypeProvider.kt#L106-L112

```
    public fun KaType.upperBoundIfFlexible(): KaType = withValidityAssertion {
        (this as? KaFlexibleType)?.upperBound ?: this
    }

    public fun KaType.lowerBoundIfFlexible(): KaType = withValidityAssertion {
        (this as? KaFlexibleType)?.lowerBound ?: this
    }
```

instead of `null` they return the given type itself.

dimonchik0036 requested a review from marcopennekamp

December 13, 2024 22:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet