-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date as Long #188
base: master
Are you sure you want to change the base?
Date as Long #188
Conversation
@pnemonic78 , the Date class was not deprecated. Many of its methods were, but not the Date class itself. It is more readable than using a long that would have to be described as a long starting at Jan 1, 1970 GMT :) |
most Java developers already know that |
It still has almost no performance gain and has a small loss in clarity to developers. It would also break backwards comparability rather seriously. I am inclined to not accept this PR. |
I know this would cause quite a bit of work on my part as a consumer of
this library.
If such a change is needed, let's find a way to so in a backwards
compatible fashion.
Thank you,
Jay
…On Tue, Jun 21, 2022, 5:14 PM KosherJava ***@***.***> wrote:
most Java developers already know that long time means milliseconds since
1970/1/1
It still has almost no performance gain and has a small loss in clarity to
developers. It would also break backwards comparability rather seriously. I
am inclined to not accept this PR.
—
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJHK2FSWEYTV3HL4KTVA43VQIWFFANCNFSM5ZJ4Z5EA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@pnemonic78 and @jgindin , |
java.util.Date
has been deprecated for many years.