Skip to content

fix(test): expect provider empty durable input - #216

Merged
marckong merged 1 commit into
mainfrom
fix/durable-no-input-e2e
Sep 19, 2026
Merged

marckong merged 1 commit into
mainfrom
fix/durable-no-input-e2e

Conversation

@tkkhq

@tkkhq tkkhq commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Tracking

Why

  • the cloud E2E test expected a missing durable input as null, while the provider passes the empty input object as the serialized value "{}"

Summary

  • update the durable start assertion to match the provider input envelope

Verification

  • gofmt -d tests/e2e/api/durable_functions_test.go
  • go test ./tests/e2e/api -run '^$'
  • git diff --check origin/main...HEAD

Copilot AI balanced review requested due to automatic review settings September 19, 2026 15:29
@tkkhq
tkkhq requested a review from a team as a code owner September 19, 2026 15:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CLAassistant

CLAassistant commented Sep 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@marckong
marckong force-pushed the fix/durable-no-input-e2e branch from 98f5804 to 37b1d24 Compare September 19, 2026 15:44

@swkeever swkeever left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable findings. The fixture echoes the raw InputPayload string, and the linked staging failure shows exactly the newly expected "echoed": "{}". Existing unit tests still verify that an omitted CLI input sends no request body. Verified: unit tests for internal/api, internal/cmd/durable, and internal/output; E2E package compilation; gofmt; and diff whitespace checks. The full cloud E2E was not rerun locally.

@marckong marckong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full diff and traced the no-input path through the CLI request, hosting handoff, and Lambda durable envelope. The assertion matches the observed provider contract while existing unit coverage continues to verify that the CLI sends an empty request body. No actionable findings; local tests/lint and required CI checks pass.

@marckong
marckong merged commit 38df432 into main Sep 19, 2026
11 of 12 checks passed
@marckong
marckong deleted the fix/durable-no-input-e2e branch September 19, 2026 16:30
@kong-volcano-app kong-volcano-app Bot mentioned this pull request Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants