Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Failed deployments currently discard the API-provided error message, preventing actionable diagnostics.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds optional waiting for submitted function deployments to reach active status.
Changes:
- Adds
functions deploy --waitfor single and batch deployments. - Polls exact deployment IDs with retry and terminal-state handling.
- Adds tests and user documentation.
File summaries
| File | Description |
|---|---|
internal/cmd/functions/deploy.go |
Implements the flag and polling workflow. |
internal/cmd/functions/deploy_test.go |
Tests success, rollback, and lookup failures. |
internal/cmd/functions/helpers_test.go |
Adds deployment response fixtures. |
docs/functions.md |
Documents --wait behavior and usage. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| case apiclient.FunctionDeploymentStatusProvisioning, | ||
| apiclient.FunctionDeploymentStatusQueued: | ||
| default: | ||
| return fmt.Errorf("function %q deployment %s finished with status %s", fn.Name, deploymentID, deployment.Status) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking
Why
Summary
functions deploy --waitfor single and batch deploymentsVerification
make lintgo test ./...go build ./...