Add extra_data parameter + Add request_url property in UnirestResponse #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty often when I make asynchronous requests I need two things that are commonly implemented in asynchronous request libraries:
Now I love using
unirest
because it's so simple and beautiful, but those are limitations that are too important to pass on.A simple example is for logging / reporting purposes, when you need to log the request URL in the response and record the HTTP code .
I add an
extra_data
andrequest_url
properties in the UnirestResponse to tackle these two problems.Example use: