feat(elasticache): add a signer for Elasticache #140
+213
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luacheck Report3 tests 3 ✅ 0s ⏱️ Results for commit 2ae5328. ♻️ This comment has been updated with latest results. |
Water-Melon
force-pushed
the
elasticache_signer
branch
3 times, most recently
from
f31b3cf to
d3e15c2
Compare
Water-Melon
changed the title
windmgc
reviewed
Oct 27, 2025
There was a problem hiding this comment.
LGTM overall. @Water-Melon can you add a mock ut to check the singer generates an expected token?
Water-Melon
force-pushed
the
elasticache_signer
branch
from
d3e15c2 to
2ae5328
Compare
Added |
windmgc
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAG-7723