Skip to content

[System]Card 323 - udpate createAccount parameter #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justmiaotou wants to merge 1 commit into
base: development
Choose a base branch
from
Open

[System]Card 323 - udpate createAccount parameter #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions firefox/data/js/newtab/knotable-views.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,15 +195,14 @@ window.KnotableViews = function(events) {
signup: function(evt) {
if (evt && evt.type === 'submit' && evt.preventDefault) evt.preventDefault();
var self = this;
// TODO mark sign up source
//var signupFrom = 8; // kNoteInstantly
var signupData = {};
var data = {};

signupData.is_register = true;
signupData.username = this.$el.find("#knotable-signup-username").val();
signupData.email = this.$el.find("#knotable-signup-email").val();
signupData.password = this.$el.find("#knotable-signup-password").val();
signupData.signup_method = 11;

if (signupData.username == "")
{
Expand Down Expand Up @@ -239,7 +238,6 @@ window.KnotableViews = function(events) {

this.$el.find("#knotable-button-signup")[0].disabled = true;
self.printStatus('');
//knoteClient.call('createAccount', signupData, null, false, false, signupFrom).then(function(userData) {
knoteClient.call('createAccount', signupData).then(function(userData) {
loginWithPassword(data.email, data.password)
.then(function(a) {
Expand Down
2 changes: 1 addition & 1 deletion firefox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"title": "Knotes",
"name": "note-instantly",
"version": "3.2.0",
"version": "3.2.1",
"description": "Super fast notes from your New Tab window",
"main": "main.js",
"author": "Knotable",
Expand Down