Skip to content

fix(nix): use cargoTestFlags instead of doCheck = false 🔧#35

Merged
Klazomenai merged 1 commit intomainfrom
fix/9-nix-cargo-test-flags
Mar 28, 2026
Merged

fix(nix): use cargoTestFlags instead of doCheck = false 🔧#35
Klazomenai merged 1 commit intomainfrom
fix/9-nix-cargo-test-flags

Conversation

@Klazomenai
Copy link
Copy Markdown
Owner

Summary

  • Replace doCheck = false with cargoTestFlags = [ "--lib" "--test" "integration" ]
  • Nix builds now run unit + integration tests in the sandbox, only skipping E2E tests that require Foundry artifacts (contracts/out/)
  • PR fix(nix): skip test compilation in Nix build 🔧 #33 merged the original doCheck = false before this fix could be pushed

Refs #9

Test plan

  • nix build .#alpha succeeds with tests running
  • CI passes (unit + integration tests)

@Klazomenai Klazomenai marked this pull request as ready for review March 28, 2026 10:49
Copilot AI review requested due to automatic review settings March 28, 2026 10:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Nix build to run Rust unit + integration tests in the sandbox while still avoiding E2E tests that depend on Foundry artifacts (contracts/out/), improving build-time confidence without reintroducing the prior sandbox failure.

Changes:

  • Replace doCheck = false with cargoTestFlags to run cargo test --lib and cargo test --test integration during Nix builds.
  • Update the inline comment to describe why E2E tests are excluded from Nix builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Replace doCheck = false with cargoTestFlags to run unit and integration
tests during Nix builds while skipping E2E tests that require Foundry
artifacts (contracts/out/). PR #33 merged the original doCheck = false
before this fix could be pushed.

Refs #9
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Klazomenai Klazomenai merged commit 34eb8b3 into main Mar 28, 2026
5 checks passed
@Klazomenai Klazomenai deleted the fix/9-nix-cargo-test-flags branch March 28, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants