fix(nix): use cargoTestFlags instead of doCheck = false 🔧#35
Merged
Klazomenai merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Nix build to run Rust unit + integration tests in the sandbox while still avoiding E2E tests that depend on Foundry artifacts (contracts/out/), improving build-time confidence without reintroducing the prior sandbox failure.
Changes:
- Replace
doCheck = falsewithcargoTestFlagsto runcargo test --libandcargo test --test integrationduring Nix builds. - Update the inline comment to describe why E2E tests are excluded from Nix builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f0051be to
8a7eb0b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doCheck = falsewithcargoTestFlags = [ "--lib" "--test" "integration" ]contracts/out/)doCheck = falsebefore this fix could be pushedRefs #9
Test plan
nix build .#alphasucceeds with tests running