Automate package publishing via CI/CD#820
Merged
zachmullen merged 7 commits intomainfrom Nov 11, 2025
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2420447 to
5e0a85e
Compare
5e0a85e to
564462a
Compare
PaulHax
approved these changes
Nov 10, 2025
Collaborator
PaulHax
left a comment
There was a problem hiding this comment.
Shall we add a section in CONTRIBUTING.md for how to do the manual version bump steps?
Now that we are distributing VolView as a package via npm, we don't want to run build steps via npm lifecycle hooks. If we need to patch the software, it needs to be codified as part of the build steps rather than at install time.
Contributor
Author
|
@PaulHax PTAL at 27c1a5a. Publishing a volview package to npm is going to necessitate at least this change. But we should also completely overhaul what packages within volview are considered dev dependencies vs. runtime dependencies. Anything that is built into the dist bundle should be moved from |
The rationale is that npmjs.org only allows a single Trusted Publisher workflow to be configured on a given npm package.
986f146 to
f71c801
Compare
This was referenced Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative proposal to #815. It has the following behavior:
vX.Y.Zto GitHub. This tag convention is already used by VolView.main, a prerelease version is published. It takes the latest stable release version from the set of manually created tags, and publishes a prerelease with thepreidofdev-<git-SHA>.devsuch that anyone who wants to follow the bleeding edge of the package cannpm install volview@devand get the latest prerelease without having to fiddle with git SHAs.Advantages:
Before we merge this, we'll need to ensure that the relevant NPM token is set in our GH Actions secrets. I also renamed
publish.ymltodocs.ymlto make the intent of each file clearer.