Upgrade to ts-rs 11.0 for TS type fixes #7581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
force-pushed
the
jtran/upgrade-ts-rs-11
branch
from
e54804a to
dbdd2d0
Compare
jacebrowning
approved these changes
Jun 24, 2025
jtran
force-pushed
the
jtran/upgrade-ts-rs-11
branch
from
dbdd2d0 to
96d98c8
Compare
CodSpeed Instrumentation Performance ReportMerging #7581 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on KittyCAD/modeling-api#898. Replaces #7573.
https://github.com/Aleph-Alpha/ts-rs/blob/main/CHANGELOG.md#1100
Before this change, a lot of serialized values from Rust omit fields if they are the default. This results in a runtime
undefinedvalue, when the TS type doesn't expect it. This PR fixes the TS types to accurately model the optional fields.