Update artifact graph only when no error #7072
Conversation
Maybe fixes #6297
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -487,10 +487,10 @@ export class KclManager { | |||
| if (!errors.length) { | |||
| this.lastSuccessfulVariables = execState.variables | |||
| this.lastSuccessfulOperations = execState.operations | |||
| // updateArtifactGraph relies on updated executeState/variables | |||
| await this.updateArtifactGraph(execState.artifactGraph) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Recording.2025-05-19.133425.mp4
There was a problem hiding this comment.
it should have everything up until the point it failed so maybe the test needs to do a bit more, your current test only has a single batch, you need more than one batch for this for work, basically extrude something then fail after that.
There was a problem hiding this comment.
Still seing an empty graph in execState with a broken sweep after a successful extrude
There was a problem hiding this comment.
What are you trying to accomplish?
When there's an error, the artifact graph and operations are properties of the KCLError instance, and the execState is a dummy. See handleExecuteError().
modeling-app/src/lang/langHelpers.ts
Line 129 in c2f6ce0
There was a problem hiding this comment.
I would consider changing handleExecuteError() to copy artifactGraph and operations to the execState to present a uniform interface. But I know that some things are only done on success or only on error, so we need to be careful.
…t-back-on-errors-to-do-selections-on-whatever-did-work
…t-back-on-errors-to-do-selections-on-whatever-did-work
Maybe fixes #6297