Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back stream idle mode #5312

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add back stream idle mode #5312

wants to merge 2 commits into from

Conversation

lf94
Copy link
Contributor

@lf94 lf94 commented Feb 7, 2025

This will probably need to be tested more, but it's ready for a review!

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app 🛑 Canceled (Inspect) Feb 7, 2025 10:30pm

Copy link

qa-wolf bot commented Feb 7, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.01%. Comparing base (67e60cb) to head (41e7503).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/settings/types/mod.rs 28.57% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5312      +/-   ##
==========================================
- Coverage   86.04%   86.01%   -0.03%     
==========================================
  Files          92       92              
  Lines       33250    33260      +10     
==========================================
  Hits        28609    28609              
- Misses       4641     4651      +10     
Flag Coverage Δ
wasm-lib 86.01% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant