Add basic axis case for Helix point-and-click #5240
Merged
+275
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
pierremtb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5240 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 92 92
Lines 33204 33204
=======================================
Hits 28575 28575
Misses 4629 4629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ection-with-offset-plane-3d-construction-elements-in-the-toolbar
…ection-with-offset-plane-3d-construction-elements-in-the-toolbar
…-offset-plane-3d-construction-elements-in-the-toolbar' into pierremtb/issue5072-add-helix-command-flow-and-generic-case
…ection-with-offset-plane-3d-construction-elements-in-the-toolbar
…ection-with-offset-plane-3d-construction-elements-in-the-toolbar
…-offset-plane-3d-construction-elements-in-the-toolbar' into pierremtb/issue5072-add-helix-command-flow-and-generic-case
Base automatically changed from
pierremtb/issue5234-Move-Helix-button-to-a-section-with-offset-plane-3d-construction-elements-in-the-toolbar
to
main
February 5, 2025 15:00
franknoirot
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
This is great. Two thoughts:
- You can probably add the "Delete" right-click menu to the operation type in the Feature Tree since deletion works already
- I can't seem to click within the stream to select the helices. I think it's possible that they aren't being added to the artifactGraph
|
@franknoirot Awesome thank you!
|
pierremtb
deleted the
pierremtb/issue5072-add-helix-command-flow-and-generic-case
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5072 #5236 #5073
Only nightly and dev for now