Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: inserting revolve command accounts for axis dependency #5231

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

nadr0
Copy link
Collaborator

@nadr0 nadr0 commented Feb 3, 2025

Issue

// pseudocode
sketch
extrude(sketch)
circleSketchedOnExtrude
constructionGeometryOfLine

When you select the circle and the construction geometry line in point and click revolve the output would be

// pseudocode
sketch
extrude(sketch)
circleSketchedOnExtrude
revolve <--this breaks because the line is after!
constructionGeometryOfLine

Implementation

If the user performs a revolve with an edge in the point and click workflow I take the max index for inserting after the sketch or the selection.

Copy link

qa-wolf bot commented Feb 3, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 10, 2025 7:32pm

@nadr0 nadr0 changed the title Fix: inserting revolve accounts for axis dependency when inserting the revolve command Fix: inserting revolve accounts for axis dependency Feb 3, 2025
@nadr0 nadr0 changed the title Fix: inserting revolve accounts for axis dependency Fix: inserting revolve command accounts for axis dependency Feb 3, 2025
Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (74bdb72) to head (361c26e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5231   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files          92       92           
  Lines       33261    33261           
=======================================
  Hits        28620    28620           
  Misses       4641     4641           
Flag Coverage Δ
wasm-lib 86.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nadr0 nadr0 merged commit e2be66b into main Feb 10, 2025
35 checks passed
@nadr0 nadr0 deleted the nadro/adhoc/revolve-insert-bug-fix branch February 10, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants