Add artifact ID to KCL values that have them #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
jtran
force-pushed
the
jtran/sketch-artifact-id
branch
from
80507ed to
1f16c85
Compare
jtran
commented
Jan 31, 2025
Comment on lines
+113
to
+122
| // TODO: We're reusing the same UUID for multiple commands. This seems | ||
| // like the artifact graph would never be able to find all the | ||
| // responses. |
There was a problem hiding this comment.
This seems like it must be a bug. Separate issue though.
jtran
force-pushed
the
jtran/sketch-artifact-id
branch
from
6469b06 to
35a285d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5205 +/- ##
==========================================
- Coverage 86.01% 86.01% -0.01%
==========================================
Files 92 92
Lines 33082 33093 +11
==========================================
+ Hits 28455 28464 +9
- Misses 4627 4629 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
franknoirot
approved these changes
Feb 3, 2025
jtran
force-pushed
the
jtran/sketch-artifact-id
branch
from
07201da to
2bd5f8d
Compare
jtran
force-pushed
the
jtran/sketch-artifact-id
branch
from
2bd5f8d to
669a7c3
Compare
jtran
force-pushed
the
jtran/sketch-artifact-id
branch
from
669a7c3 to
45053f1
Compare
jtran
force-pushed
the
jtran/sketch-artifact-id
branch
from
45053f1 to
18d5980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5186.
Weirdly, the
idof Sketch and other core structs may get mutated. Sometimes theidvalue is the same as the artifact ID, but not always. We track and expose the stable artifact ID for everything that has it. This isn't used yet, but it will be in a follow-up PR.