Rust: Remove iai benchmark tests #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
We don't get much value from these, we can always run criterion or valgrind locally. If we want to measure instruction counts, we should be using codspeed.io instead because they support visualizing and tracking over time. If we want to track performance over time we should be using Kevin's perf monitor machine.
adamchalmers
force-pushed
the
achalmers/rm-iai
branch
from
ddf0012 to
8a4cb71
Compare
jtran
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't get much value from these, we can always run criterion or valgrind locally.
If we want to measure instruction counts, we should be using codspeed.io instead because they support visualizing and tracking over time.
If we want to track performance over time we should be using Kevin's perf monitor machine.