-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom updater modal #1738
Custom updater modal #1738
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Oh sick @pierremtb! I was just about to ask how it handles a long change log before you updated the image, perfect. Could we get the markdown to render as HTML? My only thoughts while mocking up this were:
(Ignore the button styling and the fact that this modal has opened over the |
Awesome thank you @franknoirot! I'll update it to match the mockup. Yeah we can use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
=======================================
Coverage 86.45% 86.45%
=======================================
Files 54 54
Lines 22424 22424
=======================================
Hits 19387 19387
Misses 3037 3037
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Moved to draft until we merge #1400 (already rebased on it) |
Yeah no worries on the bullet points, I might be able to take a look at the CSS and fix in a follow-up PR if you should me how to test it in dev @pierremtb. |
@franknoirot Sounds good! Let's wait for the next update, this branch is easier to test when it's a version behind :) |
@franknoirot Waiting on another nightly build to verify that the regular update flow still works as expected. After that I think we should trigger a release, and then get on with this one |
Okkkkk @franknoirot we need this merged sooner than later actually 😅 I don't know how I missed this during the migration to tauri v2 #1400
We can fake a nightly build locally and point to https://storage.googleapis.com/dl.kittycad.io/releases/modeling-app/nightly/last_update.json with the following
![]() |
Todo:
@franknoirot I'll let you provide guidance on UI and UX. That's the current state of things
Tested on Windows too (no relaunch modal as it opens the msi directly)
![image](https://private-user-images.githubusercontent.com/10795683/316832186-48b68bb1-f0d5-4d3b-b08d-fc40d8b72936.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5OTgzNjUsIm5iZiI6MTczODk5ODA2NSwicGF0aCI6Ii8xMDc5NTY4My8zMTY4MzIxODYtNDhiNjhiYjEtZjBkNS00ZDNiLWIwOGQtZmM0MGQ4YjcyOTM2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDA3MDEwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY0ODg2NTczYjU0OTA1ZjFjZGE0NmIxYTI0N2QyMWMzOWNmN2M1MTY3MzdiMThjMThmMTk3MDU3MDgwMjg5NGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mEW78_0bAwE_4JhDbf4h3P8KaaqcGNg7tPsXPmB4XMM)