More Comprehensive Folia Support #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement Folia support into PlayerVaultsX with various safety checks to ensure the following (feasible) accountances are met:
Of course, this implements the generic "scheduler" modifications, whilst ensuring other areas of the code in various other PRs were also accounted for. In addition, I've implemented a "locking" mechanism that prevents races, such as two threads loading/creating different
Inventoryinstances for the same vault at the same time.Feel free to let me know if you have any additional comments, concerns, or questions. I am more than happy to improve upon this PR if you are not quite satisfied.