Skip to content

fix: Add yes flag #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterfoul wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

fix: Add yes flag #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion structures-js/structures-cli/src/commands/synchronize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export class Synchronize extends Command {
server: Flags.string({char: 's', description: 'The structures server to connect to'}),
publish: Flags.boolean({char: 'p', description: 'Publish each Entity after save/update'}),
verbose: Flags.boolean({char: 'v', description: 'Enable verbose logging'}),
yes: Flags.boolean({description: 'Automatically confirm opening the browser'}),
dryRun: Flags.boolean({description: 'Dry run enables verbose logging and does not save any changes to the server'})
}

Expand All @@ -54,7 +55,7 @@ export class Synchronize extends Command {
serverUrl = serverConfig.url
}

if (flags.dryRun || await connectAndUpgradeSession(serverUrl, this)) {
if (flags.dryRun || await connectAndUpgradeSession(serverUrl, this, flags.yes)) {
try {

if(!flags.dryRun) {
Expand Down
5 changes: 3 additions & 2 deletions structures-js/structures-cli/src/internal/Utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ export function jsonStringifyReplacer(key: any, value: any) {
* This will be replaced when the server supports a session upgrade command
* @param server the server to connect to
* @param logger the logger to use
* @param autoConfirm allow the user to skip the browser confirmation
* @return true if the session was upgraded successfully
*/
export async function connectAndUpgradeSession(server: string, logger: Logger): Promise<boolean>{
export async function connectAndUpgradeSession(server: string, logger: Logger, autoConfirm?: boolean): Promise<boolean>{
try {
const serverURL: URL = new URL(server)

Expand Down Expand Up @@ -100,7 +101,7 @@ export async function connectAndUpgradeSession(server: string, logger: Logger):
logger.log('Authenticate your account at:')
logger.log(url)

const answer = await confirm({
const answer = autoConfirm ?? await confirm({
message: 'Open in browser?',
default: true,
})
Expand Down