Repository navigation
feat(tui): add spacebar flagging and fix unrated flag scoring - #32
Conversation
Provide comprehensive details on scoring mode mechanics and trade-offs. Emphasize the 'pin a title' feature in the Live Weight Impact Preview as a key calibration strategy, offering clearer guidance for users to optimize their settings during onboarding and preferences.
Reviewer's GuideImplements a global spacebar shortcut to toggle a "flag for follow-up" state across the main DataTable, Lineup, and Interrogation Room, wires it into the Evidence Locker and evaluation pipeline, and refreshes docs, help text, screenshots, and packaging metadata for the new flagging workflow and scoring mode guidance while bumping the version to 0.1.0a6. Sequence diagram for spacebar flag toggle in main DataTablesequenceDiagram
actor User
participant NetflixNarcApp
participant DataTable
participant EvidenceLocker
User->>NetflixNarcApp: press Space
NetflixNarcApp->>DataTable: query_one(DataTable)
NetflixNarcApp->>DataTable: coordinate_to_cell_key(cursor_coordinate)
NetflixNarcApp->>NetflixNarcApp: derive base_title
NetflixNarcApp->>EvidenceLocker: toggle_flag_title(base_title)
EvidenceLocker-->>NetflixNarcApp: new_state
NetflixNarcApp->>NetflixNarcApp: refresh_title(base_title)
NetflixNarcApp->>User: notify("Flagged"/"Unflagged" for follow-up)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 87.25% 87.27% +0.02%
==========================================
Files 25 25
Lines 2896 2948 +52
==========================================
+ Hits 2527 2573 +46
- Misses 369 375 +6 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/netflix_narc/evaluator.py" line_range="651-652" />
<code_context>
return api_metadata
if not merge_manual_data or api_metadata is None:
+ if not manual_record.has_rating_data:
+ return api_metadata
return manual_record.to_normalized_metadata()
</code_context>
<issue_to_address>
**issue (bug_risk):** Guard against `manual_record` being `None` before accessing `has_rating_data`.
In this branch `manual_record` may be `None` (e.g., when there is no manual entry), so `manual_record.has_rating_data` will raise an exception. Add a guard, e.g. `if manual_record is None or not manual_record.has_rating_data:`, to preserve the previous behavior and avoid the crash.
</issue_to_address>
### Comment 2
<location path="docs/guides/tui-walkthrough.md" line_range="33" />
<code_context>
+| **Lineup Queue** | <kbd>Space</kbd> | **Flag for Follow-up** | Toggle flag for future follow-up on current card title. |
| **Lineup Queue** | <kbd>x</kbd> | **Ignore Title** | Mark current title as ignored and advance to next item. |
| **Lineup Queue** | <kbd>s</kbd> | **Skip Title** | Skip current title without modifying its status. |
+| **Interrogation** | <kbd>Space</kbd> | **Flag for Follow-up** | Toggle 'Flag for future follow-up' checkbox (when form input non-focused). |
| **Interrogation** | <kbd>F2</kbd> | **Web Search** | Open Common Sense Media search for title in default browser. |
| **Modals / Screens** | <kbd>Esc</kbd> | **Close / Back** | Dismiss current screen or modal dialog without saving changes. |
</code_context>
<issue_to_address>
**suggestion (typo):** Clarify the phrase "when form input non-focused" for grammatical correctness.
Please rephrase this condition to improve clarity, e.g. "when no form input is focused" or "when the form input is not focused."
```suggestion
| **Interrogation** | <kbd>Space</kbd> | **Flag for Follow-up** | Toggle 'Flag for future follow-up' checkbox (when no form input is focused). |
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@sourcery-ai title |
Summary by Sourcery
Add spacebar-based flagging across main table, lineup, and interrogation screens, refine scoring/metadata handling for flagged unrated titles, and publish expanded documentation with updated project metadata for version 0.1.0a6.
New Features:
Bug Fixes:
Enhancements:
Build:
Documentation:
Tests:
Chores: