Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SVG logo with PNG to fix linting error #56

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Conversation

Juice10
Copy link
Collaborator

@Juice10 Juice10 commented Mar 19, 2025

Replace the SVG logo in README.md with a PNG format to comply with linting requirements.

Error:

ERROR  SVGs are restricted in README.md; please use other file image formats, such as PNG: https://kilocode.ai/kilo-v1.svg

Juice10 added 2 commits March 19, 2025 14:24
ERROR  SVGs are restricted in README.md; please use other file image formats, such as PNG: https://kilocode.ai/kilo-v1.svg
@janpaul123
Copy link
Collaborator

Why does this lint error exist? SVGs are just better?

@Juice10
Copy link
Collaborator Author

Juice10 commented Mar 19, 2025

@janpaul123 SVG is totally better, this is a safety thing for the VS Code marketplace. Apparently they don't allow 'untrusted' SVG since you can add <script> tags into it.
Context: microsoft/vscode-vsce#183 (comment)

Copy link
Collaborator

@janpaul123 janpaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add that link as a comment next to the line you changed, for context?

@Juice10 Juice10 merged commit 08d570f into main Mar 19, 2025
6 checks passed
@Juice10 Juice10 deleted the juice10/readme-logo branch March 19, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants