Update native tool definitions to align to text and more accurately manage contract #3288
+833
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…separator - Add helper functions to detect and parse dynamic MCP tool names - Normalize dynamic tools to standard 'use_mcp_tool' format - Use triple underscores (___) as separator to allow underscores in tool names - Update tool name generation in mcp_server.ts - Add comprehensive test coverage for dynamic tool parsing - Extract toolInputProps and convert to JSON string for MCP server compatibility
…ons in text, and align required fields to disallow 'null'.
🦋 Changeset detectedLatest commit: 2d52c4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chrarnoldus
reviewed
Oct 25, 2025
| type: "array", | ||
| description: | ||
| "Optional list of 2-4 suggested responses; each suggestion must be a complete, actionable answer and may include a mode switch", | ||
| "Required list of 2-4 suggested responses; each suggestion must be a complete, actionable answer and may include a mode switch", |
There was a problem hiding this comment.
This doesn't match the XML description
There was a problem hiding this comment.
It doesn't and thats intentional. Asking a question without offering responses suggestions seems like an error, and I believe is part of the cause of some of the Promise rejections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
About half the tool definitions (which were initially generated in an automated fashion) had mild inconsistencies in their text definitions vs their required/null options.
This PR updates these definitions to be more accurate, hopefully leading to more consistent tool call behavior.