Skip to content

Conversation

@beatlevic
Copy link
Collaborator

Work around for adding responses for empty prefix

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

⚠️ No Changeset found

Latest commit: 6c9c86a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@beatlevic beatlevic requested a review from markijbema October 24, 2025 16:27
Copy link
Contributor

@markijbema markijbema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ithink we need to switch what is the fallback, but otherwise this approach and the location where the repairing is done seems good to me

prefix,
suffix,
})
// Try new FIM detection for cursor marker addition-only cases first
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to default to the "normal" Fim detection, and then try to do more complex stuff, so imho the old way should be the deault, and the new way the fallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants